LGTM

On Mon, Apr 14, 2014 at 2:55 PM, Jose A. Lopes <[email protected]> wrote:

> The sample logrotate configuration file
> (doc/examples/ganeti.logrotate) contains the following line
>
>   create 640 root root
>
> which is fine if Ganeti if configured without split users.  However,
> this will change permissions and ownership of log files if Ganeti is
> configured with split users enabled.  By removing this line, logrotate
> will preserve the permissions of the logfiles when rotating the logs.
>
> This fixes issue 789.
>
> Signed-off-by: Jose A. Lopes <[email protected]>
> ---
>  doc/examples/ganeti.logrotate.in | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/doc/examples/ganeti.logrotate.in b/doc/examples/
> ganeti.logrotate.in
> index 05b1895..dddaad0 100644
> --- a/doc/examples/ganeti.logrotate.in
> +++ b/doc/examples/ganeti.logrotate.in
> @@ -5,7 +5,6 @@
>          notifempty
>          compress
>          delaycompress
> -        create 640 root root
>          sharedscripts
>          postrotate
>                 @PKGLIBDIR@/daemon-util rotate-all-logs
> --
> 1.9.1.423.g4596e3a
>
>

Reply via email to