Within this file, quite a lot of times you are printing errors in a very specific way: kvm-vif-bridge: error error, error error. This could confuse Xen users.
Can you do another sed step for both xen-ifup-os and kvm-ifup-os where you insert the right hypervisor? On Wed, Apr 9, 2014 at 9:53 AM, Jose A. Lopes <[email protected]> wrote: > ... including a target to build this file from the KVM one, given that > they are the same. > > Signed-off-by: Jose A. Lopes <[email protected]> > --- > Makefile.am | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/Makefile.am b/Makefile.am > index 15991a2..2fc3eab 100644 > --- a/Makefile.am > +++ b/Makefile.am > @@ -278,6 +278,7 @@ CLEANFILES = \ > $(manhtml) \ > tools/kvm-ifup \ > tools/kvm-ifup-os \ > + tools/xen-ifup-os \ > tools/vif-ganeti \ > tools/net-common \ > tools/users-setup \ > @@ -340,7 +341,8 @@ BUILT_EXAMPLES = \ > doc/examples/hooks/ipsec > > dist_ifup_SCRIPTS = \ > - tools/kvm-ifup-os > + tools/kvm-ifup-os \ > + tools/xen-ifup-os > > nodist_pkgpython_PYTHON = \ > $(built_python_base_sources) \ > @@ -1212,6 +1214,7 @@ myexeclib_SCRIPTS = \ > daemons/daemon-util \ > tools/kvm-ifup \ > tools/kvm-ifup-os \ > + tools/xen-ifup-os \ > tools/vif-ganeti \ > tools/net-common \ > $(HS_MYEXECLIB_PROGS) > @@ -1745,6 +1748,10 @@ tools/kvm-ifup-os: > tools/kvm-ifup-os.in$(REPLACE_VARS_SED) > sed -f $(REPLACE_VARS_SED) < $< > $@ > chmod +x $@ > > +tools/xen-ifup-os: tools/kvm-ifup-os.in $(REPLACE_VARS_SED) > + sed -f $(REPLACE_VARS_SED) < $< > $@ > + chmod +x $@ > + > tools/vif-ganeti: tools/vif-ganeti.in $(REPLACE_VARS_SED) > sed -f $(REPLACE_VARS_SED) < $< > $@ > chmod +x $@ > -- > 1.9.1.423.g4596e3a > >
