LGTM. Thanks, Jose
On Apr 16 15:19, Ilias Tsitsimpis wrote: > Config's function names should not use abbreviations. > Update disks design doc accordingly. > > Signed-off-by: Ilias Tsitsimpis <[email protected]> > --- > doc/design-disks.rst | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/doc/design-disks.rst b/doc/design-disks.rst > index 61900cb..ec9c63d 100644 > --- a/doc/design-disks.rst > +++ b/doc/design-disks.rst > @@ -129,12 +129,12 @@ There are four operations that can be performed to a > `Disk` object: > > The first two operations will be performed using the config functions > ``AddDisk`` and ``RemoveDisk`` respectively where the last two operations > -will be performed using the functions ``AttachInstDisk`` and > -``DetachInstDisk``. > +will be performed using the functions ``AttachInstanceDisk`` and > +``DetachInstanceDisk``. > > Since Ganeti doesn't allow for a `Disk` object to not be attached anywhere > (for > -now) we will create two wrapper functions (namely ``AddInstDisk`` and > -``RemoveInstDisk``) which will add and attach a disk at the same time > +now) we will create two wrapper functions (namely ``AddInstanceDisk`` and > +``RemoveInstanceDisk``) which will add and attach a disk at the same time > (respectively detach and remove a disk). > > In addition since Ganeti doesn't allow for a `Disk` object to be attached to > -- > 1.9.1 > -- Jose Antonio Lopes Ganeti Engineering Google Germany GmbH Dienerstr. 12, 80331, München Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Graham Law, Christine Elizabeth Flores Steuernummer: 48/725/00206 Umsatzsteueridentifikationsnummer: DE813741370
