No, this is an error, thanks for spotting this. I removed it from the
patch, keeping only 2014.




On Thu, Apr 17, 2014 at 4:04 PM, Klaus Aehlig <[email protected]> wrote:

> On Thu, Apr 17, 2014 at 03:11:30PM +0200, Petr Pudlak wrote:
> > Currently it exports a function for creating livelock files.
> >
> > Signed-off-by: Petr Pudlak <[email protected]>
> > ---
> >  Makefile.am                  |  1 +
> >  src/Ganeti/Utils/Livelock.hs | 58
> ++++++++++++++++++++++++++++++++++++++++++++
> >  2 files changed, 59 insertions(+)
> >  create mode 100644 src/Ganeti/Utils/Livelock.hs
> >
> > diff --git a/Makefile.am b/Makefile.am
> > index ee0c2ae..0f65cd0 100644
> > --- a/Makefile.am
> > +++ b/Makefile.am
> > @@ -837,6 +837,7 @@ HS_LIB_SRCS = \
> >       src/Ganeti/Utils.hs \
> >       src/Ganeti/Utils/Atomic.hs \
> >       src/Ganeti/Utils/AsyncWorker.hs \
> > +     src/Ganeti/Utils/Livelock.hs \
> >       src/Ganeti/VCluster.hs \
> >       src/Ganeti/WConfd/ConfigState.hs \
> >       src/Ganeti/WConfd/ConfigWriter.hs \
> > diff --git a/src/Ganeti/Utils/Livelock.hs b/src/Ganeti/Utils/Livelock.hs
> > new file mode 100644
> > index 0000000..96659b4
> > --- /dev/null
> > +++ b/src/Ganeti/Utils/Livelock.hs
> > @@ -0,0 +1,58 @@
> > +{-| Utilities related to livelocks and death detection
> > +
> > +-}
> > +
> > +{-
> > +
> > +Copyright (C) 2013, 2014 Google Inc.
>
> Why 2013? Did you start working on this file already last year? If not,
> please remove the "2013, ".
>
> Rest LGTM
>
> --
> Klaus Aehlig
> Google Germany GmbH, Dienerstr. 12, 80331 Muenchen
> Registergericht und -nummer: Hamburg, HRB 86891
> Sitz der Gesellschaft: Hamburg
> Geschaeftsfuehrer: Graham Law, Christine Elizabeth Flores
>

Reply via email to