Hi Marco, thanks for sending us this patch, but unfortunately, it is not in a state that we can accept.
A few remarks: - Please send your changes as .patch file and not separate diffs, as those are very tedious to apply. (See the man page 'git format-patch' for details). Depending on our workload we sometimes reject patches just because of that, so if you want it to be in, please comply to the format. - You edited some files which are generated from other files and thus should not be added manually. That is 'gnt-instance.8.in' and ' gnt-instance.html.in' are generated from 'man/gnt-instance.rst' and 'ListConstants.hs' is generated from Constants.hs. I fixed that when I tried to apply your patches, but next time please take care of that yourself. Usually the files contain a header that says not to manually add them. From the Makefile you can deduce what files to actually edit. - From 2.10 to master, quite some changes in the kvm part happened, so I could not easily apply it there. Since I anyway had to move around your chunks of code, I adapted the patch to master. I will send my version of the patch to this email thread. We summarized the process how to submit patches here: https://code.google.com/p/ganeti/wiki/DeveloperGuidelines But the main problem is that it does not pass our QA. Apparently, it is not possible to create a cluster anymore with your patch, which is of course not something we can accept. You can have a look at the output of our QA here: http://buildbot.ganeti.org/ganeti/builders/qa-kvm-tiny/builds/427/steps/ganeti-qa/logs/stdio That said, this might just be the first thing that breaks, please make sure that your patch passes the test suite at least (run make 'dist-check') and try some standard operations on a cluster to make sure it does not break anything else. I hope I could help you with my hints and am looking forward to receive a working patch file soon :) Thanks, Helga On Tue, Apr 22, 2014 at 12:41 PM, Marco Casavecchia <marcoli...@gmail.com>wrote: > Hi all, > finally I found the time to make this simple patch that enables kvm to use > native AIO for the disk devices. > I made the modifications on top of the latest stable release 2.10.3, so it > should be easy to port them into the current developing branch. > It adds a new HV-KVM parameter "disk_aio" to gnt-instance and gnt-cluster > commands that can take the followings values: native or default. > > The patch also updates the man page for gnt-instance and you can find it > as attachment to this message. > I am using it in my production environment and I hope to see it become > part of the next release of Ganeti. > > Reguards by MCM. > -- -- Helga Velroyen | Software Engineer | hel...@google.com | Google Germany GmbH Dienerstr. 12 80331 München Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Graham Law, Christine Elizabeth Flores
