LGTM, thanks
On Mon, Apr 28, 2014 at 10:07 AM, 'Petr Pudlak <pud...@google.com>' via ganeti-devel <ganeti-devel@googlegroups.com> wrote: > Since _SetDrbdHelper calls methods on self.cfg, it's necessary to update > the configuration before it is called. > > Signed-off-by: Petr Pudlak <pud...@google.com> > --- > This should fix the broken master build (unless something else is broken > as > well). > > lib/cmdlib/cluster.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/cmdlib/cluster.py b/lib/cmdlib/cluster.py > index e839a9e..b1a8cd0 100644 > --- a/lib/cmdlib/cluster.py > +++ b/lib/cmdlib/cluster.py > @@ -1500,8 +1500,8 @@ class LUClusterSetParams(LogicalUnit): > > self.cluster = self.cfg.GetClusterInfo() > self._SetFileStorageDir(feedback_fn) > + self.cfg.Update(self.cluster, feedback_fn) > self._SetDrbdHelper(feedback_fn) > - self.cfg.Update(self.cluster, feedback_fn) > > # re-read the fresh configuration again > self.cluster = self.cfg.GetClusterInfo() > -- > 1.9.1.423.g4596e3a > > -- -- Helga Velroyen | Software Engineer | hel...@google.com | Google Germany GmbH Dienerstr. 12 80331 München Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Graham Law, Christine Elizabeth Flores
