Hello team,

These two patches add the 'DiskParams' slot to the Haskell's Disk
object. Since Wconfd is now responsible for writing the config file this
was causing the 'params' slot to not be written in the config file.

It seems that we have faced a similar problem again (described in issue
693). I believe that the Haskell code responsible for parsing the JSON
requests is at fault here since it ignores any data that cannot be
matched with the Objects whereas the right thing to do is to report an
error (just like the Python parsing code does). Could you please have a
look at that? I believe we could prevent a lot of feature bugs if we fix
this.

Thanks,

Ilias Tsitsimpis (2):
  Rename DiskParams to GroupDiskParams
  Add DiskParams to Disk object

 src/Ganeti/Config.hs           |  2 +-
 src/Ganeti/Objects.hs          | 15 ++++++++++-----
 src/Ganeti/OpCodes.hs          |  6 +++---
 src/Ganeti/OpParams.hs         |  6 +++---
 test/hs/Test/Ganeti/Objects.hs | 18 +++++++++++-------
 5 files changed, 28 insertions(+), 19 deletions(-)

-- 
2.0.0.rc0

Reply via email to