(+ list)
On Tue, May 20, 2014 at 3:39 PM, Helga Velroyen <[email protected]> wrote: > LGTM, thanks > > > On Tue, May 20, 2014 at 2:59 PM, Dimitris Aragiorgis <[email protected]>wrote: > >> All instance related opcodes that use the --net option >> were broken because luxid was not passing the network parameter >> to the corresponding LU. >> >> Fix this. >> >> Signed-off-by: Dimitris Aragiorgis <[email protected]> >> --- >> src/Ganeti/OpParams.hs | 1 + >> test/hs/Test/Ganeti/OpCodes.hs | 2 +- >> 2 files changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/src/Ganeti/OpParams.hs b/src/Ganeti/OpParams.hs >> index 5453b89..201ff44 100644 >> --- a/src/Ganeti/OpParams.hs >> +++ b/src/Ganeti/OpParams.hs >> @@ -344,6 +344,7 @@ $(buildObject "INicParams" "inic" >> , optionalField $ simpleField C.inicName [t| NonEmptyString |] >> , optionalField $ simpleField C.inicVlan [t| String |] >> , optionalField $ simpleField C.inicBridge [t| NonEmptyString |] >> + , optionalField $ simpleField C.inicNetwork [t| NonEmptyString |] >> ]) >> >> -- | Disk modification definition. >> diff --git a/test/hs/Test/Ganeti/OpCodes.hs >> b/test/hs/Test/Ganeti/OpCodes.hs >> index 2f5a233..cebedc5 100644 >> --- a/test/hs/Test/Ganeti/OpCodes.hs >> +++ b/test/hs/Test/Ganeti/OpCodes.hs >> @@ -89,7 +89,7 @@ instance Arbitrary INicParams where >> arbitrary = INicParams <$> genMaybe genNameNE <*> genMaybe genName <*> >> genMaybe genNameNE <*> genMaybe genNameNE <*> >> genMaybe genNameNE <*> genMaybe genName <*> >> - genMaybe genNameNE >> + genMaybe genNameNE <*> genMaybe genNameNE >> >> instance Arbitrary IDiskParams where >> arbitrary = IDiskParams <$> arbitrary <*> arbitrary <*> >> -- >> 1.7.10.4 >> >> > > > -- > -- > Helga Velroyen | Software Engineer | [email protected] | > > Google Germany GmbH > Dienerstr. 12 > 80331 München > > Registergericht und -nummer: Hamburg, HRB 86891 > Sitz der Gesellschaft: Hamburg > Geschäftsführer: Graham Law, Christine Elizabeth Flores > -- -- Helga Velroyen | Software Engineer | [email protected] | Google Germany GmbH Dienerstr. 12 80331 München Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Graham Law, Christine Elizabeth Flores
