Hi

(I'm replying to the thread with the original patch. Please reply to this
thread too with everything regarding the patch, it's much easier to track
both for me and other team members. Also when resubmitting a patch, use
--in-reply-to git option with the MessageID of the original thread so that
the new version also follows the thread, as described in
https://code.google.com/a/google.com/p/ganeti-eng/wiki/GanetiDevelopment#Reviews.)

I looked at the patch again, and I'd say the problem is a bit more complex.
After adding *group_name* to both *GenericInstanceCreate* method and
*IAReqInstanceAlloc*, it's necessary to track all uses of these and supply
the parameter. This involves some decisions: for operations that indirectly
use them, we either need to add the parameter (if it makes sense), or
supply None for *group_name*. And *GenericInstanceCreate* is a bit more
tricky, because *group_name* is hidden in it's *opts* argument (and the
lack of types in Python makes it impossible to find other than by manual
work).

Let me know if I can help any further.

  Best regards,
  Petr

Reply via email to