LGTM

On Tue, Jun 03, 2014 at 12:33:31PM +0200, 'Klaus Aehlig' via ganeti-devel wrote:
> noded is designed to live on a normal node and hence
> will not depend on any other daemon. In particular, it
> is safe to start this daemon first. Starting it after
> wconfd also allows wconfd to carry out a full voting.
> 
> Signed-off-by: Klaus Aehlig <[email protected]>
> ---
>  daemons/daemon-util.in            | 2 +-
>  test/py/daemon-util_unittest.bash | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/daemons/daemon-util.in b/daemons/daemon-util.in
> index a77f1d3..88479db 100644
> --- a/daemons/daemon-util.in
> +++ b/daemons/daemon-util.in
> @@ -28,8 +28,8 @@ readonly defaults_file="$SYSCONFDIR/default/ganeti"
>  # order is important as there are dependencies between them. On shutdown,
>  # they're stopped in reverse order.
>  DAEMONS=(
> -  ganeti-wconfd
>    ganeti-noded
> +  ganeti-wconfd
>    ganeti-rapi
>    ganeti-luxid
>    )
> diff --git a/test/py/daemon-util_unittest.bash 
> b/test/py/daemon-util_unittest.bash
> index 07fe1b0..463bcda 100755
> --- a/test/py/daemon-util_unittest.bash
> +++ b/test/py/daemon-util_unittest.bash
> @@ -36,8 +36,8 @@ if ! grep -q '^ENABLE_MOND = ' lib/_constants.py; then
>    err "Please update $0, mond enable feature is missing"
>  fi
>  
> -DAEMONS_LIST="wconfd noded rapi luxid"
> -STOPDAEMONS_LIST="luxid rapi noded wconfd"
> +DAEMONS_LIST="noded wconfd rapi luxid"
> +STOPDAEMONS_LIST="luxid rapi wconfd noded"
>  
>  if grep -q '^ENABLE_CONFD = True' lib/_constants.py; then
>    DAEMONS_LIST="$DAEMONS_LIST confd"
> -- 
> 1.9.1.423.g4596e3a
> 

Reply via email to