Good idea, I'll resend the two patches.
On Wed, Jun 4, 2014 at 1:35 PM, Klaus Aehlig <[email protected]> wrote: > On Wed, Jun 04, 2014 at 12:29:19PM +0200, 'Petr Pudlak' via ganeti-devel > wrote: > > That is, for a pair "group" and "volume". > > > > The data type (de)serializes to/from JSON as a String of the form > > "group/volume". > > > > Signed-off-by: Petr Pudlak <[email protected]> > > --- > > src/Ganeti/DataCollectors/Lv.hs | 5 ++- > > src/Ganeti/Objects.hs | 78 > ++++++++++++++++++++++++++++++++++++----- > > 2 files changed, 72 insertions(+), 11 deletions(-) > > Maybe move the fixing part of the next patch into this patch instead? > > In any case: LGTM. > > -- > Klaus Aehlig > Google Germany GmbH, Dienerstr. 12, 80331 Muenchen > Registergericht und -nummer: Hamburg, HRB 86891 > Sitz der Gesellschaft: Hamburg > Geschaeftsfuehrer: Graham Law, Christine Elizabeth Flores >
