LGTM, thanks
On Fri, Jun 6, 2014 at 10:51 AM, 'Jose A. Lopes' via ganeti-devel < [email protected]> wrote: > ... in 'seqSplit' and 'parseChoices'. > > Signed-off-by: Jose A. Lopes <[email protected]> > --- > src/Ganeti/Utils.hs | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/Ganeti/Utils.hs b/src/Ganeti/Utils.hs > index e8cac42..c516fb7 100644 > --- a/src/Ganeti/Utils.hs > +++ b/src/Ganeti/Utils.hs > @@ -137,7 +137,7 @@ applyIf b f x = if b then f x else x > commaJoin :: [String] -> String > commaJoin = intercalate "," > > --- | Split a list on a separator and return an array. > +-- | Split a list on a separator and return a list of lists. > sepSplit :: Eq a => a -> [a] -> [[a]] > sepSplit sep s > | null s = [] > @@ -237,7 +237,7 @@ if' _ _ y = y > -- * Parsing utility functions > > -- | Parse results from readsPrec. > -parseChoices :: (Monad m, Read a) => String -> String -> [(a, String)] -> > m a > +parseChoices :: Monad m => String -> String -> [(a, String)] -> m a > parseChoices _ _ ((v, ""):[]) = return v > parseChoices name s ((_, e):[]) = > fail $ name ++ ": leftover characters when parsing '" > -- > 2.0.0.526.g5318336 > >
