On Fri, Jun 13, 2014 at 06:04:52PM +0200, 'Petr Pudlak' via ganeti-devel wrote: > Instead of generating loadOpCode and saveOpCode, generate the DictObject > instance, which also allows to list used keys (currently it doesn't). > Use this instance to construct JSON instances for OpCode and MetaOpCode. > > In order to do this: > > - The types of genSaveOpCode and genLoadOpCode functions were unified > and now return list of clauses, instead of a complete declaration > (so that the clauses can be used to construct the instance). > - Currently the DictObject instance for OpCode doesn't compute the used > keys, it just reports that all keys are used. > - The old genSaveOpCode function was kept and renamed to genSaveOpCode', > because it's still used for Luxi op-codes. > > Signed-off-by: Petr Pudlak <[email protected]> > --- > src/Ganeti/OpCodes.hs | 30 ++++++++------------- > src/Ganeti/THH.hs | 73 > ++++++++++++++++++++++++++++++++++----------------- > 2 files changed, 60 insertions(+), 43 deletions(-)
LGTM -- Klaus Aehlig Google Germany GmbH, Dienerstr. 12, 80331 Muenchen Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschaeftsfuehrer: Graham Law, Christine Elizabeth Flores
