LGTM, thanks
On Wed, Jun 25, 2014 at 11:23 AM, 'Klaus Aehlig' via ganeti-devel < [email protected]> wrote: > This option will be used to tell hspace to ignore > existing N+1 violations and allocate on all non-affected > nodes as usual. > > Signed-off-by: Klaus Aehlig <[email protected]> > --- > src/Ganeti/HTools/CLI.hs | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/src/Ganeti/HTools/CLI.hs b/src/Ganeti/HTools/CLI.hs > index 6a212d4..d267282 100644 > --- a/src/Ganeti/HTools/CLI.hs > +++ b/src/Ganeti/HTools/CLI.hs > @@ -62,6 +62,7 @@ module Ganeti.HTools.CLI > , oIgnoreDyn > , oIgnoreNonRedundant > , oIndependentGrps > + , oAcceptExisting > , oInstMoves > , oJobDelay > , genOLuxiSocket > @@ -128,6 +129,7 @@ data Options = Options > , optDynuFile :: Maybe FilePath -- ^ Optional file with dynamic use > data > , optIgnoreDynu :: Bool -- ^ Do not use dynamic use data > , optIndependentGrps :: Bool -- ^ consider groups independently > + , optAcceptExisting :: Bool -- ^ accept existing N+1 violations > , optMonD :: Bool -- ^ Query MonDs > , optMonDFile :: Maybe FilePath -- ^ Optional file with data provided > -- ^ by MonDs > @@ -184,6 +186,7 @@ defaultOptions = Options > , optDiskMoves = True > , optInstMoves = True > , optIndependentGrps = False > + , optAcceptExisting = False > , optDiskTemplate = Nothing > , optSpindleUse = Nothing > , optIgnoreDynu = False > @@ -364,6 +367,13 @@ oIndependentGrps = > "Consider groups independently", > OptComplNone) > > +oAcceptExisting :: OptType > +oAcceptExisting = > + (Option "" ["accept-existing-errors"] > + (NoArg (\ opts -> Ok opts {optAcceptExisting = True})) > + "Accept existing N+1 violations; just don't add new ones", > + OptComplNone) > + > oEvacMode :: OptType > oEvacMode = > (Option "E" ["evac-mode"] > -- > 2.0.0.526.g5318336 > >
