Updates:
        Labels: -Milestone-Release2.12 Milestone-Release2.13

Comment #1 on issue 785 by [email protected]: Move the configuration consistency check to WConfd
http://code.google.com/p/ganeti/issues/detail?id=785

Currently the configuration checks work correctly in 2.12, as the job acquires WConfd's configuration lock (see the patches below). While we want to get rid of configuration locks outside WConfd eventually, it's not a blocking issue for 2.12.

commit 7f8ba25ba174173e58e73ff76e29e82de79e3c38
Author: Petr Pudlak <[email protected]>
Date:   Thu May 29 16:35:01 2014 +0200

    Move configuration flush to a synchronized block

    This ensures that the configuration is fully distributed and doesn't
    change during the verification process.

    Signed-off-by: Petr Pudlak <[email protected]>
    Reviewed-by: Klaus Aehlig <[email protected]>

commit f6004843a44c28d9b5a2ad474d730cfaa44fa30f
Author: Petr Pudlak <[email protected]>
Date:   Mon Mar 31 11:52:07 2014 +0200

    Acquire config lock for RPC calls that check consistency

    Since LUClusterVerifyGroup issues 3 RPC calls to get information from
    nodes, and during every of these calls, the configuration can be
    modified by somebody else, it's necessary to acquire a shared lock on
    the configuration.

    All the RPC calls are grouped together in a block that holds the lock,
    and the tests are only performed afterwards, after the lock is released.

    This should be later moved into WConfd, which can prevent configuration
    changes internally.

    Signed-off-by: Petr Pudlak <[email protected]>
    Reviewed-by: Klaus Aehlig <[email protected]>


--
You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

Reply via email to