On Fri, Jul 04, 2014 at 01:18:13PM +0200, 'Petr Pudlak' via ganeti-devel wrote:
> .. so that tests that require these calls still work.
> 
> Also use the mocked configuration for some tests that require
> functions related to IP reservations.
> 
> Signed-off-by: Petr Pudlak <[email protected]>
> ---
>  test/py/cmdlib/testsupport/config_mock.py | 93 
> ++++++++++++++++++++++++++++++-
>  test/py/ganeti.config_unittest.py         | 14 +++--
>  2 files changed, 100 insertions(+), 7 deletions(-)

LGTM

(well, not really, as getting rid of the code would be better,
 but as long as user so-called "unit tests" assume a full daemon
 there is, unfortunately, little we can do)

-- 
Klaus Aehlig
Google Germany GmbH, Dienerstr. 12, 80331 Muenchen
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschaeftsfuehrer: Graham Law, Christine Elizabeth Flores

Reply via email to