On Mon, Aug 11, 2014 at 07:08:12AM -0700, Hrvoje Ribicic wrote:
> Reformulated commit message:
> 
> Allow instance disks to be added with --no-wait-for-sync
> 
> The patch 3c260845147c6dad35e37c03ba9a7556814f3f3f fixed a bug where
> adding a new disk to an instance with deactivated disks activated the
> disk. However, it also introduced some erroneous behaviour, preventing
> disks from being added to online instances with --no-wait-for-sync.
> 
> In line with the original meaning of the patch, this patch modifies the
> check to disallow adding disks to shutdown instances with
> --no-wait-for-sync, and allow doing so for online instances.

LGTM

-- 
Klaus Aehlig
Google Germany GmbH, Dienerstr. 12, 80331 Muenchen
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschaeftsfuehrer: Graham Law, Christine Elizabeth Flores

Reply via email to