Hi! thanks for the patch. We discussed this in the team and as this option was introduced in 2.9 already, we will not change the command line option anymore - as you said already - to not break any scripts that expect it. We would rather change the documentation to point it to the correct command line option name.
I filed a bug for it: https://code.google.com/p/ganeti/issues/detail?id=915 Of course, if you want to sent us a patch for updating the documentation, we are more than happy to accept it! :) Cheers, Helga On Wed, Aug 6, 2014 at 5:33 PM, Rowan Thorpe <[email protected]> wrote: > The commit which originally added the --print-jobid flag also added > documentation for --print-job-id in several places, and the discrepancy > has stayed in place across several releases, so --print-job-id was > obviously the intended flag and the single occurrence of --print-jobid > must have been a typo. NB: this change will impact on anyone who might > have scripted use of the flag (which is how I found the problem). > > Signed-off-by: Rowan Thorpe <[email protected]> > --- > lib/cli.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/cli.py b/lib/cli.py > index e939b5c..d894825 100644 > --- a/lib/cli.py > +++ b/lib/cli.py > @@ -875,7 +875,7 @@ SUBMIT_OPT = cli_option("--submit", dest="submit_only", > help=("Submit the job and return the job ID, but" > " don't wait for the job to finish")) > > -PRINT_JOBID_OPT = cli_option("--print-jobid", dest="print_jobid", > +PRINT_JOBID_OPT = cli_option("--print-job-id", dest="print_jobid", > default=False, action="store_true", > help=("Additionally print the job as first > line" > " on stdout (for scripting).")) > -- > 2.0.1 > > -- Helga Velroyen | Software Engineer | [email protected] | Google Germany GmbH Dienerstr. 12 80331 München Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Graham Law, Christine Elizabeth Flores
