LGTM, thanks
On Tue, Aug 12, 2014 at 7:24 PM, Yuto KAWAMURA(kawamuray) < [email protected]> wrote: > Fix statements which using result.Raise in invalid form. > Change comma to '%' operator to provide a formatted string as these > lines originally expected. > > Signed-off-by: Yuto KAWAMURA(kawamuray) <[email protected]> > --- > lib/cmdlib/instance_operation.py | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/lib/cmdlib/instance_operation.py > b/lib/cmdlib/instance_operation.py > index 788b496..a9c6102 100644 > --- a/lib/cmdlib/instance_operation.py > +++ b/lib/cmdlib/instance_operation.py > @@ -176,7 +176,7 @@ class LUInstanceStartup(LogicalUnit): > self.instance.primary_node, > self.instance, > self.op.shutdown_timeout, self.op.reason) > - result.Raise("Could not shutdown instance '%s'", > self.instance.name) > + result.Raise("Could not shutdown instance '%s'" % > self.instance.name) > > ShutdownInstanceDisks(self, self.instance) > > @@ -189,7 +189,7 @@ class LUInstanceStartup(LogicalUnit): > self.op.startup_paused, > self.op.reason) > if result.fail_msg: > ShutdownInstanceDisks(self, self.instance) > - result.Raise("Could not start instance '%s'", self.instance.name) > + result.Raise("Could not start instance '%s'" % self.instance.name > ) > > > class LUInstanceShutdown(LogicalUnit): > @@ -291,7 +291,7 @@ class LUInstanceShutdown(LogicalUnit): > self.instance.primary_node, > self.instance, > self.op.timeout, self.op.reason) > - result.Raise("Could not shutdown instance '%s'", self.instance.name > ) > + result.Raise("Could not shutdown instance '%s'" % > self.instance.name) > > ShutdownInstanceDisks(self, self.instance) > > -- > 2.0.4 > > -- Helga Velroyen | Software Engineer | [email protected] | Google Germany GmbH Dienerstr. 12 80331 München Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Graham Law, Christine Elizabeth Flores
