Il 13/ago/2014 16:24 "'Aaron Karper' via ganeti-devel" < [email protected]> ha scritto: > > This series introduces the config.data cluster configuration for data > collectors - in this case to turn them off. MonD talks to the ConfD to get the > relevant configuration and doesn't show the DC under /1/list/collectors >
This is an interesting implementation, and we can indeed keep it (you never know, people might want to manually deactivate data collectors). But what was actually required, was a way to automatically deactivate collectors that Ganeti already knows can never be useful. Currently, the only example of this is the instance status collector for xen: if looking at the configuration of the cluster xen is not found among the enabled hypervisors, we know that there's no point in showing it. The user should not bother deactivating the collector manually. So I'd say: add this on top of the current infrastructure you've already built, it should be really quick. Also, given that you added the possibility to manually disable any collector, at this point a disabled one should not just disappear from the list, but should also not provide its output when directly queried (otherwise I think users would be quite surprised by this functionality). Could you make this two modifications? Thanks, Michele > Aaron Karper (2): > Add option to deactivate data collectors in config.data > Add `gnt-cluster modify --[de]activate-data-collector` > > lib/client/gnt_cluster.py | 28 ++++++++++- > lib/cmdlib/cluster.py | 6 +++ > lib/objects.py | 1 + > src/Ganeti/Confd/Server.hs | 5 ++ > src/Ganeti/Confd/Types.hs | 1 + > src/Ganeti/Constants.hs | 14 ++++++ > src/Ganeti/Monitoring/Server.hs | 57 +++++++++++++++++----- > src/Ganeti/Objects.hs | 105 +++++++++++++++++++++------------------- > src/Ganeti/OpCodes.hs | 2 + > src/Ganeti/OpParams.hs | 14 ++++++ > src/Ganeti/Query/Server.hs | 2 + > src/ganeti-mond.hs | 20 ++++++-- > test/hs/Test/Ganeti/Objects.hs | 9 ++++ > test/hs/Test/Ganeti/OpCodes.hs | 9 ++++ > test/py/cfgupgrade_unittest.py | 7 +++ > tools/cfgupgrade | 9 ++++ > 16 files changed, 222 insertions(+), 67 deletions(-) > > -- > 2.1.0.rc2.206.gedb03e5 >
