On Thu, Sep 11, 2014 at 12:47:45AM +0300, Dimitris Aragiorgis wrote: > The xen-hvm hypervisor has two extra hvparams concerning NICS; > nic_type, and vif_type. Let _WriteNicConfig() calculate all needed > extra options for the instance's NICs based on its hvparams. > > Signed-off-by: Dimitris Aragiorgis <[email protected]> > --- > lib/hypervisor/hv_xen.py | 31 ++++++++++++++++--------------- > 1 file changed, 16 insertions(+), 15 deletions(-)
> @@ -560,9 +560,24 @@ class XenHypervisor(hv_base.BaseHypervisor): > """ > raise NotImplementedError > > - def _WriteNicConfig(self, config, instance, hvp, nic_type_str=""): > + def _WriteNicConfig(self, config, instance, hvp): > vif_data = [] This patch removes the keyword argument nc_type_str from _WriteNicConfig while the call to that function at line 1419 still uses this keyword argument. Can you please modify the patch so that it takes into account all call sites to this function? Thanks, Klaus -- Klaus Aehlig Google Germany GmbH, Dienerstr. 12, 80331 Muenchen Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschaeftsfuehrer: Graham Law, Christine Elizabeth Flores
