On Mon, Sep 29, 2014 at 7:26 PM, Yuto KAWAMURA(kawamuray) < [email protected]> wrote:
> Currently there's no hvparam modification tests for LXC hypervisor, so we > there are no => plural follows the LXC hypervisor > should add additional LXC hypervisor specific parameters that can be > LXC-specific parameters => shorter, uses hyphen to indicate grouping > used for instance modification tests of hypervisor parameters. > > Signed-off-by: Yuto KAWAMURA(kawamuray) <[email protected]> > --- > qa/qa_instance.py | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/qa/qa_instance.py b/qa/qa_instance.py > index 10735e5..1c34db2 100644 > --- a/qa/qa_instance.py > +++ b/qa/qa_instance.py > @@ -643,6 +643,11 @@ def TestInstanceModify(instance): > ["--disk", "-1:add,size=1G", "--hotplug"], > ["--disk", "-1:remove", "--hotplug"], > ]) > + elif default_hv == constants.HT_LXC: > + args.extend([ > + ["-H", "%s=" % constants.HV_CPU_MASK], > + ["-H", "%s=0" % constants.HV_LXC_TTY], > + ]) > Note that all of the preceding tests take care to set a value to some non-default state, and then revert it back to the default. This is useful as we are doing real modifications on the instance, and having it stuck in a strange state might propagate to cause trouble later. So here, assign a real mask to the CPU mask param, and revert the TTY param to the default. > > # OS Parameters validation failed on node > node01.19528.qa-sandbox.ganeti: The following parameters are not supported > by the OS debootstrap: os-image > # url = "http://example.com/busybox.img"; > -- > 1.8.5.5 > >
