Alright, will push this once the tests run through. Cheers, Helga
On Mon, Oct 6, 2014 at 10:08 AM, Apollon Oikonomopoulos <apoi...@gmail.com> wrote: > Hi Petr, > > On 09:56 Mon 06 Oct , Petr Pudlák wrote: > > I guess it's better to have a know workaround (that we can eventually > > remove later) than not being able to run at all on some systems. > > > > I wonder, do all possible Linux systems support /proc/self/fd/ for sure? > I > > guess yes, I just wanted to be sure. > > /proc/self/fd is a stable interface, has been there for ages and its > symlink semantics are well documented (see proc(5)). The only potential > problem is that a system might not have /proc mounted (although that's > very, very unlikely and will cause lots of other things not to work). > However, we already rely on /proc being mounted in a couple of places > throughout the code (e.g. when accessing /proc/drbd), so we're not > really adding extra restrictions here. > > Regards, > Apollon > > > > > Other than that LGTM. > > > > On Mon, Oct 6, 2014 at 9:03 AM, Apollon Oikonomopoulos < > apoi...@gmail.com> > > wrote: > > > > > On 21:14 Sat 04 Oct , Apollon Oikonomopoulos wrote: > > > > As we cannot reliably detect neither the GnuTLS version, nor the > > > > socket, we > > > > work our way around this by keeping all fds referring to /dev/urandom > > > open > > > > after fork. We do so using the /proc/self/fd interface. > > > > > > Note that I have mixed feelings about this. I view it mostly as a > GnuTLS > > > misbehavior and do not really like adding workarounds in Ganeti for > > > libraries that are 3 layers below. I am preparing 2.11.6-2 for Debian > > > which will include this patch (otherwise Ganeti won't work in jessie), > > > but feel free *not* to commit it if you do not think it's appropriate. > > > > > > Regards, > > > Apollon > > > > -- Helga Velroyen | Software Engineer | hel...@google.com | Google Germany GmbH Dienerstr. 12 80331 München Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Graham Law, Christine Elizabeth Flores
