On 12/01/2014 08:16 PM, 'Klaus Aehlig' via ganeti-devel wrote:
For generated files, it is enough to check the headers of the
files they are generated from. Moreover, the generated files
have the shebang-line of the target system, which might be
different from the generic one checked for.

Signed-off-by: Klaus Aehlig <[email protected]>
---
  Makefile.am | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/Makefile.am b/Makefile.am
index dbe867e..44ba84f 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -2048,7 +2048,8 @@ check-news:
  .PHONY: check-local
  check-local: check-dirs check-news $(GENERATED_FILES)
        $(CHECK_PYTHON_CODE) $(check_python_code)
-       PYTHONPATH=. $(CHECK_HEADER) $(check_python_code)
+       PYTHONPATH=. $(CHECK_HEADER) \
+           $(filter-out $(GENERATED_FILES),$(check_python_code))
        $(CHECK_VERSION) $(VERSION) $(top_srcdir)/NEWS
        PYTHONPATH=. $(RUN_IN_TEMPDIR) $(CURDIR)/$(CHECK_IMPORTS) . 
$(standalone_python_modules)
        error= ; \


LGTM

--
Niklas Hambüchen
Google Germany GmbH, Dienerstr. 12, 80331 Muenchen
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschaeftsfuehrer: Graham Law, Christine Elizabeth Flores

Reply via email to