On Fri, Jan 09, 2015 at 05:49:46PM +0100, Klaus Aehlig wrote:
> > +LUXI and IAllocator protocol extension
> > +--------------
> > +
> > +The LUXI and IAllocator protocols are extended to include in the ``node``:
> > +
> > +* ``storage``: a list of objects (storage units) with
> > +  # Storage unit, containing in order:
> > +      # storage type
> > +      # storage key (e.g. volume group name)
> > +      # extra parameters (e.g. flag for exclusive storage) as a list.
> > +  # Amount free in MiB
> > +  # Amount total in MiB
> > +
> > +.. code-block:: javascript
> > +
> > +    {
> > +      "storage": [
> > +        { "sunit": ["drbd8", "xenvg", [false]]
> 
> what is this false supposed to signal? Exclusive storage is
> not available for drbd, as drbd always depends on the network
> (and hence not exclusive on operations of the very instance).
> 

Right, I removed it and see below for the definition of the drbd storage
type.

> > +        , "free": 2000,
> > +        , "total": 4000
> > +        },
> > +        { "sunit": ["file", "/path/to/storage1", []]
> > +        , "free": 5000,
> > +        , "total": 10000
> > +        },
> > +        { "sunit": ["file", "/path/to/storage2", []]
> > +        , "free": 1000,
> > +        , "total": 20000
> > +        },
> > +        { "sunit": ["lvm-vg", "xenssdvg", [false]]
> > +        , "free": 1024,
> > +        , "total": 1024
> > +        }
> > +      ]
> > +    }
> > +
> > +is a node with an LVM volume group mirrored over DRBD, two file storage
> > +directories, one half full, one mostly full, and a non-mirrored volume 
> > group.
> > +
> > +The storage type ``drbd8`` needs to be added in order to differentiate 
> > between
> > +mirrored storage and non-mirrored storage.

+The storage key signals the volume group used and the storage unit takes no
+additional parameters.

> > +
> 
> Rest LGTM
> 
> -- 
> Klaus Aehlig
> Google Germany GmbH, Dienerstr. 12, 80331 Muenchen
> Registergericht und -nummer: Hamburg, HRB 86891
> Sitz der Gesellschaft: Hamburg
> Geschaeftsfuehrer: Graham Law, Christine Elizabeth Flores

-- 
Google Germany GmbH
Dienerstr. 12
80331 München

Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschäftsführer: Graham Law, Christine Elizabeth Flores

Reply via email to