LGTM, just please indent the commit lines by 2 spaces (no need to resend), thanks
On Tue, Jan 20, 2015 at 3:10 PM, 'Aaron Karper' via ganeti-devel < [email protected]> wrote: > commit 79fe9330ddc47062434f792254df45ef775d9dd8 > Merge: 89e230a 3ce0c35 > Author: Aaron Karper <[email protected]> > Date: Tue Jan 20 15:03:52 2015 +0100 > > Merge branch 'stable-2.14' > > * stable-2.14 > tests.cmdlib: Test detach/attach for file disks > tests.filestorage: Test if rename works properly > cmdlib: Rename file disk in attach/detach > filestorage: Enable the Rename action > cmdlib: Create wrapper for GenerateDiskTemplate > config: Add SetDiskLogicalID function > constants: Add new disk template set > doc: Add design doc for detached file-based disks > > Signed-off-by: Aaron Karper <[email protected]> >
