On Wed, Jan 21, 2015 at 01:28:01PM +0100, 'Aaron Karper' via ganeti-devel wrote: > Currently the tests check that if the text backend doesn't have the > exact correct number of arguments that the parse will always fail. > Since we want the HTools protocols to be extensible, additional > fields should be ignored, not expected to give an error. > > Signed-off-by: Aaron Karper <akar...@google.com> > --- > test/hs/Test/Ganeti/HTools/Backend/Text.hs | 15 +++++++++------ > 1 file changed, 9 insertions(+), 6 deletions(-)
While I'm happy with the net effect on our code base, I don't like the idea of smashing two unrelated changes in the same patch. - the actual widening of the constraints which is also mentione in the log message - the clean up of repeating code > +toYN :: Bool -> String > +toYN True = "Y" > +toYN False = "N" > + Can you please split this into two patches, each addressing one aspect. That would make history more easy to understand and simplify cherry picks, if needed. -- Klaus Aehlig Google Germany GmbH, Dienerstr. 12, 80331 Muenchen Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschaeftsfuehrer: Graham Law, Christine Elizabeth Flores
