On Tue, Mar 17, 2015 at 05:31:30PM +0100, Petr Pudlak wrote:
> From: Niklas Hambuechen <[email protected]>
> 
> When the forked (Python) job process dies for any reason, then the next `read`
> from its pipe will fail, giving an unhelpful error like:
> 
>    GenericError "<file descriptor: 13>: hWaitForInput: end of file"
> 
> This message is also returned to whoever started the job, e.g. a CLI or RAPI
> invocation. It does not say more than "in some server using some FD failed",
> which doesn't help tracking down the issue.
> 
> This commit makes the error location more descriptive, turning it into
> either of:
> 
>   "<file descriptor: 13>: ganeti job process input pipe: end of file
>   "<file descriptor: 13>: ganeti job process output pipe: end of file
> 
> Signed-off-by: Niklas Hambuechen <[email protected]>
> Signed-off-by: Klaus Aehlig <[email protected]>
> Reviewed-by: Klaus Aehlig <[email protected]>
> 
> Conflicts:
>       src/Ganeti/Query/Exec.hs - merge changes from both branches
> 
> Cherry-picked-from: 2823704fac79b11d1990fce9366375e145cb8f88
> Signed-off-by: Petr Pudlak <[email protected]>
> ---
>  src/Ganeti/Query/Exec.hs | 14 +++++++++++++-
>  1 file changed, 13 insertions(+), 1 deletion(-)

LGTM

-- 
Klaus Aehlig
Google Germany GmbH, Dienerstr. 12, 80331 Muenchen
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschaeftsfuehrer: Graham Law, Christine Elizabeth Flores

Reply via email to