LGTM On Wed, 25 Mar 2015 at 12:51 Helga Velroyen <[email protected]> wrote:
> On Wed, 25 Mar 2015 at 12:41 Petr Pudlak <[email protected]> wrote: > >> On Wed, Mar 25, 2015 at 11:36:42AM +0000, Helga Velroyen wrote: >> >Is there an actual reason for the upper limit? If not, can we just drop >> it >> >so that we don't have to update it everytime new version is released? >> >> There is an ongoing debate about this (like [1]), but I'm strongly in >> favor >> of having upper bounds. The systems that use Ganeti usually don't have >> bleeding edge Haskell libraries installed anyway, and for users it's much >> more practical. If they don't have the right version, they just get a >> meaningful error message. It's worse if they have a newer version that >> produces compilation errors uncomprehensible to them, as it happened with >> lens and monad-control recently. >> >> [1] http://neilmitchell.blogspot.de/2014/11/upper-bounds-or-not.html > > > I see your point, but given our workload I doubt we have enough time to > track every single new version of every library and update it fast enough. > This way people run into this error message which artificially prevents > them from using Ganeti although the new version would actually be able to > handle it. > > >> >> >> > >> >On Wed, 25 Mar 2015 at 10:02 'Petr Pudlak' via ganeti-devel < >> >[email protected]> wrote: >> > >> >> .. as the support for 1.0+ versions was cherry-picked to 2.12. >> >> >> >> Signed-off-by: Petr Pudlak <[email protected]> >> >> --- >> >> cabal/ganeti.template.cabal | 2 +- >> >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> >> >> diff --git a/cabal/ganeti.template.cabal b/cabal/ganeti.template.cabal >> >> index 779521b..b1b41d1 100644 >> >> --- a/cabal/ganeti.template.cabal >> >> +++ b/cabal/ganeti.template.cabal >> >> @@ -59,7 +59,7 @@ library >> >> , json >= 0.5 && < 0.9 >> >> , lens >= 3.10 && < 4.8 >> >> , lifted-base >= 0.2.0.3 && < 0.3 >> >> - , monad-control >= 0.3.1.3 && < 0.4 >> >> + , monad-control >= 0.3.1.3 && < 1.1 >> >> , MonadCatchIO-transformers >= 0.3.0.0 && < 0.4 >> >> , network >= 2.3.0.13 && < 2.7 >> >> , parallel >= 3.2.0.2 && < 3.3 >> >> -- >> >> 2.2.0.rc0.207.ga3a616c >> >> >> >> >> >
