On Mon, Apr 13, 2015 at 11:10:49AM +0200, 'Helga Velroyen' via ganeti-devel 
wrote:
> As the LURenewCrypto is a pain to debug, this patch
> adds a lot more logging of events to the method.
> Note:
> - As renew-crypto is a relatively rarely used operation
>   in a normal production cluster, this won't clutter up
>   real user's log files.
> - Most of the messages are in debug mode, so they would
>   anyway just show up in log files of clusters run in
>   debug mode (as for example our QA clusters.
> - A few log messages are in error mode, which is
>   intentional as they log more details about the errors
>   than is given in the feedback functions.
> 
> Signed-off-by: Helga Velroyen <[email protected]>
> ---
>  lib/cmdlib/cluster.py | 47 ++++++++++++++++++++++++++++++++++++++++++-----
>  1 file changed, 42 insertions(+), 5 deletions(-)

LGTM

-- 
Klaus Aehlig
Google Germany GmbH, Dienerstr. 12, 80331 Muenchen
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschaeftsfuehrer: Graham Law, Christine Elizabeth Flores

Reply via email to