On Wed, Apr 15, 2015 at 11:58:33AM +0200, Klaus Aehlig wrote:
It could be handy to have the list of external/shared disk templates
(that can be moved anywhere) as a constant. I thought Constants.hs
might be a good fit, but unfortunately the constants there are just
'FrozenSet String', which is not very useful for Haskell. So
probably only after some refactoring of Constants.hs.
Alternatively, we can have a predicate
templateFreelyMovable :: DiskTemplate -> Bool
in src/Ganeti/Types.hs where the type DiskTemplate is defined.
If we define that predicate without wildcard patters, we will
always be forced to think about movability of new template whenever
we add one.
If you agree, I'll push the current patch series as is and address
that in a follow-up patch series.
LGTM
Thanks,
Klaus
Good idea, let's do it like that (in another patch series).
Thanks
Petr
--
Klaus Aehlig
Google Germany GmbH, Dienerstr. 12, 80331 Muenchen
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschaeftsfuehrer: Graham Law, Christine Elizabeth Flores
