On Mon, Apr 20, 2015 at 11:00:52AM +0200, 'Lisa Velden' via ganeti-devel wrote:
Signed-off-by: Lisa Velden <[email protected]>
---
lib/serializer.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/serializer.py b/lib/serializer.py
index c63577b..b4d5631 100644
--- a/lib/serializer.py
+++ b/lib/serializer.py
@@ -256,7 +256,7 @@ class Private(object):
    return "<%s>" % self._descr

  def __repr__(self):
-    return "Private(?, descr=%r)".format(self._descr)
+    return "Private(?, descr=%r)" % self._descr

I'd suggest to use one-element tuple, to make it unambiguous, that is

  .. % (self._descr, )

Rest LGTM, thanks


  # pylint: disable=W0212
  # If it doesn't access _item directly, the call will go through __getattr__
--
2.2.0.rc0.207.ga3a616c

Reply via email to