On Tue, Apr 21, 2015 at 09:45:03AM +0000, 'BSRK Aditya' via ganeti-devel wrote: > The modifications to ConfigState for AddInstanceDisk > and AttachInstanceDisk are now done in WConfd daemon > instead of using ConfigSync to do the modification > from python codebase. > > This eliminates _UnlockedAddInstanceDisk, and > _UnlockedAttachInstanceDisk, but introduces them > in the python tests to simulate the behaviour > of AddInstanceDisk and AttachInstanceDisk without > making a call to WConfd. > > Signed-off-by: BSRK Aditya <[email protected]> > --- > lib/config/__init__.py | 87 +++---------------- > src/Ganeti/WConfd/ConfigModifications.hs | 133 > ++++++++++++++++++++++++++++-- > test/py/ganeti.config_unittest.py | 13 --- > test/py/testutils/config_mock.py | 24 ++++++ > 4 files changed, 160 insertions(+), 97 deletions(-)
LGTM -- Klaus Aehlig Google Germany GmbH, Dienerstr. 12, 80331 Muenchen Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschaeftsfuehrer: Graham Law, Christine Elizabeth Flores
