> >+ conflicts = itags.intersection(itags) > > This was probably meant to be itags.intersection(tag_seen)
yes, you're right. commit 91b0d5bbce4ce19f786d1f91540cba084186977c Author: Klaus Aehlig <[email protected]> Date: Thu Apr 23 12:39:48 2015 +0200 Interdiff [PATCH master 6/6] Also check exclusion tags in cluster verify diff --git a/lib/cmdlib/cluster/verify.py b/lib/cmdlib/cluster/verify.py index a2dde60..a9c6b34 100644 --- a/lib/cmdlib/cluster/verify.py +++ b/lib/cmdlib/cluster/verify.py @@ -1780,7 +1780,7 @@ class LUClusterVerifyGroup(LogicalUnit, _VerifyErrors): allitags = [] itags = set([tag for tag in allitags if utils.IsGoodTag(exclusion_prefixes, tag)]) - conflicts = itags.intersection(itags) + conflicts = itags.intersection(tags_seen) if len(conflicts) > 0: conflicting_tags = conflicting_tags.union(conflicts) tags_seen = tags_seen.union(itags) > Rest LGTM Thanks. -- Klaus Aehlig Google Germany GmbH, Dienerstr. 12, 80331 Muenchen Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschaeftsfuehrer: Graham Law, Christine Elizabeth Flores
