LGTM, thanks On Tue, 28 Apr 2015 at 15:25 'Klaus Aehlig' via ganeti-devel < [email protected]> wrote:
> Unfortunately, the intended use case for writeConfigWithImmediate, that > is an early unlocking of the configuration in writeConfigAndUnlock leads > to small window where by killing WConfD with signal 9, the configuration > can be brought into an inconsistent state. Hence we aborted this approach. > > Signed-off-by: Klaus Aehlig <[email protected]> > --- > src/Ganeti/WConfd/ConfigWriter.hs | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/src/Ganeti/WConfd/ConfigWriter.hs > b/src/Ganeti/WConfd/ConfigWriter.hs > index 7022f11..f3dd8dd 100644 > --- a/src/Ganeti/WConfd/ConfigWriter.hs > +++ b/src/Ganeti/WConfd/ConfigWriter.hs > @@ -38,7 +38,6 @@ module Ganeti.WConfd.ConfigWriter > ( loadConfigFromFile > , readConfig > , writeConfig > - , writeConfigWithImmediate > , saveConfigAsyncTask > , distMCsAsyncTask > , distSSConfAsyncTask > @@ -101,13 +100,6 @@ readConfig = csConfigData <$> readConfigState > writeConfig :: ConfigData -> WConfdMonad () > writeConfig cd = modifyConfigState $ const ((), mkConfigState cd) > > --- Replaces the current configuration state within the 'WConfdMonad', > --- immediately followed by another action (while config writeout is > --- still happening). > -writeConfigWithImmediate :: ConfigData -> WConfdMonad () -> WConfdMonad () > -writeConfigWithImmediate cd act = > - flip modifyConfigStateWithImmediate act $ const ((), mkConfigState cd) > - > -- * Asynchronous tasks > > -- | Runs the given action on success, or logs an error on failure. > -- > 2.2.0.rc0.207.ga3a616c > >
