On Tue, May 19, 2015 at 02:31:02PM +0200, 'BSRK Aditya' via ganeti-devel wrote:
> Config modifications are now done using
> wconfd RPCs.
> 
> Added wrappers CommitTemporaryIps, and VerifyConfigAndLog
> to perform read only config operations with lock.
> 
> Add a mock for Update function, and use
> the mock config object in two config tests.
> 
> Remove config tests on Update
> 
> Signed-off-by: BSRK Aditya <[email protected]>
> ---
>  lib/config/__init__.py            | 58 
> +++++++++++++++------------------------
>  test/py/ganeti.config_unittest.py | 58 
> ++-------------------------------------
>  test/py/testutils/config_mock.py  | 26 ++++++++++++++++++
>  3 files changed, 50 insertions(+), 92 deletions(-)

LGTM

-- 
Klaus Aehlig
Google Germany GmbH, Dienerstr. 12, 80331 Muenchen
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschaeftsfuehrer: Graham Law, Christine Elizabeth Flores

Reply via email to