On Thu, May 21, 2015 at 02:35:10PM +0200, 'BSRK Aditya' via ganeti-devel wrote:
> They include updateCluster, updateNode,
> updateInstance, updateNodegroup, updateNetwork,
> updateDisk.
> 
> Signed-off-by: BSRK Aditya <[email protected]>
> ---
>  src/Ganeti/WConfd/ConfigModifications.hs |  163 
> +++++++++++++++++++++++++++++-
>  1 file changed, 160 insertions(+), 3 deletions(-)

> +-- | Updates an object present in a container.
> +-- The presense of the object in the container

s/presense/presence

> +-- is determined by the uuid of the object.
> +--
> +-- A check that serial number of the
> +-- object is consistent with the serial number
> +-- of the object in the container is performed.
> +--
> +-- If the check passes, the object's serial number
> +-- is incremented, and modification time is updated,
> +-- and then is inserted into the container.


> +-- | Utility fuction that combines the two
> +-- possible actions that could be taken when
> +-- given a target.
> +--
> +-- If the target is identical to the current
> +-- value, we return the modification tim of

s/tim/time

> +-- the current value, and not change the config.
> +--

Rest LGTM. As discussed in person, will fix the typos before
pushing.

-- 
Klaus Aehlig
Google Germany GmbH, Dienerstr. 12, 80331 Muenchen
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschaeftsfuehrer: Graham Law, Christine Elizabeth Flores

Reply via email to