On Tue, May 26, 2015 at 01:58:27PM +0200, 'BSRK Aditya' via ganeti-devel wrote: > Lenses are currently not generated for > simple fields, as their types in the forthcoming > and real variants are not equal (And hence no simple > lens can be generated). However we can still generate > a more complex lens of type Lens s s (Maybe a) a. > > This will let us use set and over (but now view) for > these fields. > > Signed-off-by: BSRK Aditya <[email protected]> > --- > src/Ganeti/THH.hs | 76 > +++++++++++++++++++++++++++++++++-------------------- > 1 file changed, 48 insertions(+), 28 deletions(-)
LGTM -- Klaus Aehlig Google Germany GmbH, Dienerstr. 12, 80331 Muenchen Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschaeftsfuehrer: Graham Law, Christine Elizabeth Flores
