On Mon, 15 Jun 2015 at 18:16 'Klaus Aehlig' via ganeti-devel < [email protected]> wrote:
> In order to support automatic choice of the secondary node > in case of a disk-template conversion to DRBD, we need to > pass the IAllocator to be used. So extend the OpCode accordingly > Nit: full stop at the end? > > Signed-off-by: Klaus Aehlig <[email protected]> > --- > src/Ganeti/OpCodes.hs | 1 + > test/hs/Test/Ganeti/OpCodes.hs | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/src/Ganeti/OpCodes.hs b/src/Ganeti/OpCodes.hs > index c95cc38..173aaf2 100644 > --- a/src/Ganeti/OpCodes.hs > +++ b/src/Ganeti/OpCodes.hs > @@ -687,6 +687,7 @@ $(genOpCode "OpCode" > , withDoc > "Secondary node UUID (used when changing disk template)" > pRemoteNodeUuid > + , pIallocator > , pOsNameChange > , pInstOsParams > , pInstOsParamsPrivate > diff --git a/test/hs/Test/Ganeti/OpCodes.hs > b/test/hs/Test/Ganeti/OpCodes.hs > index f3fc33d..77e1f37 100644 > --- a/test/hs/Test/Ganeti/OpCodes.hs > +++ b/test/hs/Test/Ganeti/OpCodes.hs > @@ -413,6 +413,7 @@ instance Arbitrary OpCodes.OpCode where > <*> return Nothing -- pnode_uuid > <*> genMaybe genNodeNameNE -- remote_node > <*> return Nothing -- remote_node_uuid > + <*> genMaybe genNameNE -- iallocator > <*> genMaybe genNameNE -- os_name > <*> pure emptyJSObject -- osparams > <*> genMaybe arbitraryPrivateJSObj -- osparams_private > -- > 2.2.0.rc0.207.ga3a616c > > LGTM, thanks
