LGTM, thanks On Tue, 16 Jun 2015 at 18:20 'Klaus Aehlig' via ganeti-devel < [email protected]> wrote:
> ...to allow users to only verify the disks in a > certain node group. > > Signed-off-by: Klaus Aehlig <[email protected]> > --- > src/Ganeti/OpCodes.hs | 3 ++- > test/hs/Test/Ganeti/OpCodes.hs | 3 ++- > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/src/Ganeti/OpCodes.hs b/src/Ganeti/OpCodes.hs > index 173aaf2..271b409 100644 > --- a/src/Ganeti/OpCodes.hs > +++ b/src/Ganeti/OpCodes.hs > @@ -186,7 +186,8 @@ $(genOpCode "OpCode" > , ("OpClusterVerifyDisks", > [t| JobIdListOnly |], > OpDoc.opClusterVerifyDisks, > - [], > + [ pOptGroupName > + ], > []) > , ("OpGroupVerifyDisks", > [t| (Map String String, [String], Map String [[String]]) |], > diff --git a/test/hs/Test/Ganeti/OpCodes.hs > b/test/hs/Test/Ganeti/OpCodes.hs > index 4f6a2a5..dfcb483 100644 > --- a/test/hs/Test/Ganeti/OpCodes.hs > +++ b/test/hs/Test/Ganeti/OpCodes.hs > @@ -183,7 +183,8 @@ instance Arbitrary OpCodes.OpCode where > OpCodes.OpClusterVerifyGroup <$> genNameNE <*> arbitrary <*> > arbitrary <*> genListSet Nothing <*> genListSet Nothing <*> > arbitrary <*> arbitrary > - "OP_CLUSTER_VERIFY_DISKS" -> pure OpCodes.OpClusterVerifyDisks > + "OP_CLUSTER_VERIFY_DISKS" -> > + OpCodes.OpClusterVerifyDisks <$> genMaybe genNameNE > "OP_GROUP_VERIFY_DISKS" -> > OpCodes.OpGroupVerifyDisks <$> genNameNE > "OP_CLUSTER_REPAIR_DISK_SIZES" -> > -- > 2.2.0.rc0.207.ga3a616c > >
