On Fri, Jun 26, 2015 at 03:02:27AM +0300, Oleg Ponomarev wrote: > Signed-off-by: Oleg Ponomarev <[email protected]> > --- > src/Ganeti/HTools/Cluster/Moves.hs | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/Ganeti/HTools/Cluster/Moves.hs > b/src/Ganeti/HTools/Cluster/Moves.hs > index 560c248..4b98e20 100644 > --- a/src/Ganeti/HTools/Cluster/Moves.hs > +++ b/src/Ganeti/HTools/Cluster/Moves.hs > @@ -148,7 +148,7 @@ applyMoveEx force nl inst (ReplaceAndFailover new_pdx) = > tgt_n = Container.find new_pdx nl > int_p = Node.removePri old_p inst > int_s = Node.removeSec old_s inst > - new_inst = Instance.setBoth (setInstanceLocationScore inst int_s tgt_n) > + new_inst = Instance.setBoth (setInstanceLocationScore inst tgt_n int_p) > new_pdx old_pdx > force_s = Node.offline old_s || force > new_nl = do -- OpResult
Thanks for the patch! You did find a real bug here. Interestingly enough that bug is also present in stable-2.14, but didn't matter there, as setInstanceLocation was still symmetric at that time. Note that the test you added as second patch to that series depends on a not yet pushed series, so I can't push that series now; in fact, it would be better to combine the two patch series and putting this pach here as a new first patch of the combined series. Thanks, Klaus -- Klaus Aehlig Google Germany GmbH, Dienerstr. 12, 80331 Muenchen Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschaeftsfuehrer: Graham Law, Christine Elizabeth Flores
