On Thu, Jun 25, 2015 at 05:32:00PM +0200, 'Helga Velroyen' via ganeti-devel 
wrote:
> So far the generation of client certificates was only
> called from ssl_update.py used in when calling 'gnt-cluster
> renew-crypto'. This patch moves the function from
> ssl_update.py to tools/common.py, because it will also
> be needed by prepare_node_join.py when adding nodes
> (see next patch in the series).
> 
> Signed-off-by: Helga Velroyen <[email protected]>
> ---
>  lib/tools/common.py                         | 30 +++++++++++
>  lib/tools/ssl_update.py                     | 31 +----------
>  test/py/ganeti.tools.common_unittest.py     | 82 ++++++++++++++++++++++++++++
>  test/py/ganeti.tools.ssl_update_unittest.py | 84 
> -----------------------------
>  4 files changed, 113 insertions(+), 114 deletions(-)
>  create mode 100755 test/py/ganeti.tools.common_unittest.py
>  delete mode 100755 test/py/ganeti.tools.ssl_update_unittest.py

LGTM

-- 
Klaus Aehlig
Google Germany GmbH, Dienerstr. 12, 80331 Muenchen
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschaeftsfuehrer: Graham Law, Christine Elizabeth Flores

Reply via email to