We usually write the summary/log mesage as imperative/present tense and not past tense. So it'd like to replace "Developed" by "Develop" in the summary line.
On Tue, Jun 30, 2015 at 07:02:46PM +0300, Oleg Ponomarev wrote: > There are four tests: > * the simple one (one instance failover) > * more complex (concerning two instances) > * multiple desired locations (all can be satisfied) > * multiple desired locations (some of them can't be satisfied) > > Signed-off-by: Oleg Ponomarev <[email protected]> > --- > test/data/htools/hbal-desiredlocation-1.data | 9 +++++++++ > test/data/htools/hbal-desiredlocation-2.data | 11 +++++++++++ > test/data/htools/hbal-desiredlocation-3.data | 12 ++++++++++++ > test/data/htools/hbal-desiredlocation-4.data | 11 +++++++++++ > test/hs/shelltests/htools-hbal.test | 29 > ++++++++++++++++++++++++++++ > 5 files changed, 72 insertions(+) > create mode 100644 test/data/htools/hbal-desiredlocation-1.data > create mode 100644 test/data/htools/hbal-desiredlocation-2.data > create mode 100644 test/data/htools/hbal-desiredlocation-3.data > create mode 100644 test/data/htools/hbal-desiredlocation-4.data > diff --git a/test/hs/shelltests/htools-hbal.test > b/test/hs/shelltests/htools-hbal.test > index e3baf37..d6e15ad 100644 > --- a/test/hs/shelltests/htools-hbal.test > +++ b/test/hs/shelltests/htools-hbal.test > @@ -25,6 +25,35 @@ > node-04 0/ > >>>= 0 > > +./test/hs/hbal --print-nodes=name,pcnt -t > $TESTDATA_DIR/hbal-desiredlocation-1.data > +>>>2/Final cluster status: > + Name pcnt > + node-01 0 > + node-02 1/ > +>>>= 0 > + > +./test/hs/hbal --print-nodes=name,pcnt -t > $TESTDATA_DIR/hbal-desiredlocation-2.data > +>>>2/Final cluster status: > + Name pcnt > + node-01 1 > + node-02 1/ That trailing slash is wrong. > + node-03 0/ > +>>>= 0 > + > +./test/hs/hbal --print-nodes=name,pcnt -t > $TESTDATA_DIR/hbal-desiredlocation-3.data > +>>>2/Final cluster status: > + Name pcnt > + node-01 0 > + node-02 0 > + node-03 1/ > +>>>= 0 > + > +./test/hs/hbal --print-nodes=name,pcnt -t > $TESTDATA_DIR/hbal-desiredlocation-4.data > +>>>2/Final cluster status: > + Name pcnt > + node-01 0 > + node-02 1/ > +>>>= 0 Rest LGTM. If you agree, I'll add these two changes to your patch and push then. OK? -- Klaus Aehlig Google Germany GmbH, Dienerstr. 12, 80331 Muenchen Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschaeftsfuehrer: Graham Law, Christine Elizabeth Flores
