----- Forwarded message from Petr Pudl??k <[email protected]> ----- Date: Tue, 7 Jul 2015 10:23:27 +0200 From: Petr Pudl??k <[email protected]> To: Klaus Aehlig <[email protected]> Subject: Re: [PATCH stable-2.12 0/7] Define the list of ssconf keys at one global place In-Reply-To: <[email protected]> Message-ID: <CANKVOP8PAJBeAHgsNdE8YMZa=am_5uoqer5ayhaaxun3ffd...@mail.gmail.com>
The motivation was that it's something that should have been done in 2.12 before and also I wanted to make sure that everything regarding SSConf is checked after the recent addition. But you're right, it's not an actual bug, so I'll resend the series for master. On Tue, Jul 7, 2015 at 10:04 AM, Klaus Aehlig <[email protected]> wrote: > On Mon, Jul 06, 2015 at 07:12:30PM +0200, 'Petr Pudlak' via ganeti-devel > wrote: > > Previously we had the Haskell data type, a hard-coded list of allowed > ssconf > > keys in Python and individual ssconf constants. > > > > This series defines one global list of all ssconf keys in Constants and > also > > uses it to derive the Haskell data type from it. > > > > Also adds a test to check that WConfd creates ssconf entries for all > possible > > keys. > > As far as I can see, this patch series only does some refactoring, not part > of fixing any actual bug. So what is the motivation of sending it out for > a bug-fix--only branch like stable-2.12 ? > > -- > Klaus Aehlig > Google Germany GmbH, Dienerstr. 12, 80331 Muenchen > Registergericht und -nummer: Hamburg, HRB 86891 > Sitz der Gesellschaft: Hamburg > Geschaeftsfuehrer: Graham Law, Christine Elizabeth Flores > -- Petr Pudl??k Software Engineer [email protected] ??? Google Germany GmbH Dienerstra??e 12 80331 M??nchen Gesch??ftsf??hrer: Graham Law, Christine Elizabeth Flores Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Diese E-Mail ist vertraulich. Wenn Sie nicht der richtige Adressat sind, leiten Sie diese bitte nicht weiter, informieren Sie den Absender und l??schen Sie die E-Mail und alle Anh??nge. Vielen Dank. This e-mail is confidential. If you are not the right addressee please do not forward it, please inform the sender, and please erase this e-mail including any attachments. Thanks. ----- End forwarded message ----- -- Klaus Aehlig Google Germany GmbH, Dienerstr. 12, 80331 Muenchen Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschaeftsfuehrer: Graham Law, Christine Elizabeth Flores
