LGTM, thanks On Mon, Jul 6, 2015 at 10:20 PM, 'Lisa Velden' via ganeti-devel < [email protected]> wrote:
> The opcde OpTestOsParams for gnt-debug test-osparams has to be added > to the list of opcodes which can contain secret parameters. This is > necessary to determine the secret parameters that are handed over in > the last step of forking a job process. > > Signed-off-by: Lisa Velden <[email protected]> > --- > src/Ganeti/Query/Exec.hs | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/src/Ganeti/Query/Exec.hs b/src/Ganeti/Query/Exec.hs > index 054342a..124f7f3 100644 > --- a/src/Ganeti/Query/Exec.hs > +++ b/src/Ganeti/Query/Exec.hs > @@ -205,8 +205,9 @@ filterSecretParameters = > getSecretParams :: OpCode -> Maybe (JSObject (Secret JSValue)) > getSecretParams opcode = > case opcode of > - (OpInstanceCreate {}) -> opOsparamsSecret opcode > - (OpInstanceReinstall {}) -> opOsparamsSecret opcode > + (OpInstanceCreate {opOsparamsSecret = x}) -> x > + (OpInstanceReinstall {opOsparamsSecret = x}) -> x > + (OpTestOsParams {opOsparamsSecret = x}) -> x > _ -> Nothing > > -- | Forks a child POSIX process, creating a bi-directional communication > -- > 2.4.3.573.g4eafbef > > Hrvoje Ribicic Ganeti Engineering Google Germany GmbH Dienerstr. 12, 80331, München Geschäftsführer: Graham Law, Christine Elizabeth Flores Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg
