On Fri, Jul 17, 2015 at 01:10:36PM +0200, 'Helga Velroyen' via ganeti-devel 
wrote:
> This patch makes the node_daemon_setup tool use some of
> the recently introduced functions in the tools/common.py.
> By doing that, this also cleans up the correct usage of
> cluster name constants.
> 
> Signed-off-by: Helga Velroyen <[email protected]>
> ---
>  lib/tools/common.py                                |   6 +-
>  lib/tools/node_daemon_setup.py                     | 100 +--------------
>  lib/tools/prepare_node_join.py                     |   2 +-
>  lib/tools/ssh_update.py                            |   2 +-
>  lib/tools/ssl_update.py                            |   2 +-
>  test/py/ganeti.tools.common_unittest.py            |  85 ++++++++++++-
>  test/py/ganeti.tools.node_daemon_setup_unittest.py | 138 
> ---------------------
>  7 files changed, 94 insertions(+), 241 deletions(-)

LGTM

-- 
Klaus Aehlig
Google Germany GmbH, Dienerstr. 12, 80331 Muenchen
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschaeftsfuehrer: Graham Law, Christine Elizabeth Flores

Reply via email to