On Mon, Aug 03, 2015 at 04:23:58PM +0200, 'Klaus Aehlig' via ganeti-devel wrote:
After submitting the jobs for harep-style repair in the
maintenance daemon, we register the jobs we submitted.
To avoid serial bumps, we only do this, if the change
is a no-op, i.e., if we didn't submit any jobs. To check
for this, we have to look at the new jobs, not the old
ones. Fix this.
Signed-off-by: Klaus Aehlig <[email protected]>
---
src/Ganeti/MaintD/Server.hs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/Ganeti/MaintD/Server.hs b/src/Ganeti/MaintD/Server.hs
index 5cf35de..33aa804 100644
--- a/src/Ganeti/MaintD/Server.hs
+++ b/src/Ganeti/MaintD/Server.hs
@@ -137,7 +137,7 @@ maintenance memstate = do
nl = cdNodes cData
nidxs = Set.fromList $ Container.keys nl
(nidxs', jobs) <- harepTasks (nl, il) nidxs
- unless (null oldjobs)
+ unless (null jobs)
. liftIO $ appendJobs memstate jobs
logDebug $ "Nodes unaffected by harep " ++ show (Set.toList nidxs')
++ ", jobs submitted " ++ show (map fromJobId jobs)
--
2.5.0.rc2.392.g76e840b
LGTM, thanks
