> > +-- * MaintD tag prefixes > > + > > +maintdSuccessTagPrefix :: String > > +maintdSuccessTagPrefix = "maintd:repairready:" > > + > > +maintdFailureTagPrefix :: String > > +maintdFailureTagPrefix = "maintd:repairfailed:" > > > > I'd suggest to make a constant for the 'maintd' prefix and composing the > others with it. But that's just a nit, your call.
FYI commit 0cfd6c05ca419e2d658f7546a271353e8e3722ea Author: Klaus Aehlig <[email protected]> Date: Fri Aug 28 14:24:30 2015 +0200 Interdiff diff --git a/src/Ganeti/Constants.hs b/src/Ganeti/Constants.hs index 21a2f0e..adf7832 100644 --- a/src/Ganeti/Constants.hs +++ b/src/Ganeti/Constants.hs @@ -5445,8 +5445,11 @@ exTagsPrefix = Tags.exTagsPrefix -- * MaintD tag prefixes +maintdPrefix :: String +maintdPrefix = "maintd:" + maintdSuccessTagPrefix :: String -maintdSuccessTagPrefix = "maintd:repairready:" +maintdSuccessTagPrefix = maintdPrefix ++ "repairready:" maintdFailureTagPrefix :: String -maintdFailureTagPrefix = "maintd:repairfailed:" +maintdFailureTagPrefix = maintdPrefix ++ "repairfailed:" > LGTM, thanks (no need to resend) Thanks -- Klaus Aehlig Google Germany GmbH, Dienerstr. 12, 80331 Muenchen Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschaeftsfuehrer: Graham Law, Christine Elizabeth Flores
