On Thu, Sep 03, 2015 at 03:52:19PM +0200, Hrvoje Ribicic wrote: > LGTM with nits
Thanks. FYI, this results in the followin interdiff commit d6a03505864fc788c4b1e6cb1b685efae1c33faa Author: Klaus Aehlig <[email protected]> Date: Thu Sep 3 15:57:18 2015 +0200 Interdiff 2 diff --git a/doc/design-memory-over-commitment.rst b/doc/design-memory-over-commitment.rst index 5489a9a..d32479a 100644 --- a/doc/design-memory-over-commitment.rst +++ b/doc/design-memory-over-commitment.rst @@ -112,7 +112,7 @@ Changes to the memory policy The memory policy will be changed in that we assume that one byte of physical node memory can hold ``memory-ratio`` bytes of instance memory, but still only one byte of Ganeti memory. Of course, in practise -this has to be backed by swap space; it is the administrator responsibility +this has to be backed by swap space; it is the administrator's responsibility to ensure that each node has swap of at least ``(memory-ratio - 1.0) * (memory_total - memory_dom0)``. Ganeti will warn if the amount of swap space is not big enough. @@ -138,7 +138,7 @@ The new memory policy will be as follows. - The definition of N+1 redundancy (including :doc:`design-shared-storage-redundancy`) is kept literally as is. - Note, however, that the meaning does change, as definition depends + Note, however, that the meaning does change, as the definition depends on the notion of allowed moves, which is changed by this proposal. @@ -174,7 +174,7 @@ memory). The weighting for this metric component will have to be determined by experimentation and will depend on the memory ratio; for a memory ratio of ``1.0`` the weight will be ``0.0``, as memory need not be taken into account if no over-commitment is in place. -As a starting point for experimenation we will use weight ``0.0`` +As a starting point for experimentation we will use weight ``0.0`` if the memory ratio is ``1.0`` and weight ``1.0`` if it is bigger than ``1.0``. -- Klaus Aehlig Google Germany GmbH, Dienerstr. 12, 80331 Muenchen Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschaeftsfuehrer: Graham Law, Christine Elizabeth Flores
