On Tue, Sep 22, 2015 at 2:50 PM, 'Bhimanavajjula Aditya' via ganeti-devel <
[email protected]> wrote:

> The previous default value causes burnin to fail at instance
> creation as the disk size was too low.
>
> Signed-off-by: Bhimanavajjula Aditya <[email protected]>
> ---
>  lib/tools/burnin.py | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/lib/tools/burnin.py b/lib/tools/burnin.py
> index 6271701..a84c75b 100755
> --- a/lib/tools/burnin.py
> +++ b/lib/tools/burnin.py
> @@ -159,9 +159,8 @@ OPTIONS = [
>    cli.OSPARAMS_OPT,
>    cli.cli_option("--disk-size", dest="disk_size",
>                   help="Disk size (determines disk count)",
> -                 default="128m", type="string", metavar="<size,size,...>",
> -                 completion_suggest=("128M 512M 1G 4G 1G,256M"
> -                                     " 4G,1G,1G 10G").split()),
>

The additional comma-separated options here should be left in the
suggestion menu, as they serve to test multi-disk configurations.


> +                 default="1G", type="string", metavar="<size,size,...>",
> +                 completion_suggest="1G 2G 4G".split()),
>

Please leave in 512M, as it has proven to be enough to run some simpler OS
definitions we have lying around.


>    cli.cli_option("--disk-growth", dest="disk_growth", help="Disk growth",
>                   default="128m", type="string",
> metavar="<size,size,...>"),
>    cli.cli_option("--mem-size", dest="mem_size", help="Memory size",
> --
> 2.6.0.rc0.131.gf624c3d
>
>
Hrvoje Ribicic
Ganeti Engineering
Google Germany GmbH
Dienerstr. 12, 80331, München

Geschäftsführer: Graham Law, Christine Elizabeth Flores
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg

Reply via email to